[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror |
Date: |
Fri, 24 Jul 2020 18:46:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/24/20 4:46 PM, Daniel P. Berrangé wrote:
> On Fri, Jul 24, 2020 at 04:32:19PM +0200, Thomas Huth wrote:
>> Compiler warnings currently go unnoticed in our FreeBSD and macOS builds,
>> since -Werror is only enabled for Linux and MinGW builds by default. So
>> let's enable them here now, too.
>> For macOS, that unfortunately means that we have to disable the vnc-sasl
>> feature, since this is marked as deprecated in the macOS headers and thus
>> generates a lot of deprecation warnings.
>
> I wonder if its possible to add
>
> #pragma GCC diagnostic push
> #pragma GCC diagnostic ignored "-Wdeprecated"
>
> ...
>
> #pragma GCC diagnostic pop
>
> to silence just one source file ?
3 years ago Peter said:
"The awkward part is
that it has to be in force at the point where the deprecated
function is used, not where it's declared. So you can't just wrap
the #include of the ssl header in pragmas, you'd have to either
do it at every callsite or else over the whole .c file."
https://www.mail-archive.com/qemu-devel@nongnu.org/msg459264.html
I guess we were expecting the distrib to update the pkg.
>
>
> Regards,
> Daniel
>
- [PATCH 0/3] Improve FreeBSD and macOS jobs in the Cirrus-CI, Thomas Huth, 2020/07/24
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Peter Maydell, 2020/07/24
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Christian Schoenebeck, 2020/07/24
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Daniel P . Berrangé, 2020/07/27
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Thomas Huth, 2020/07/28
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Daniel P . Berrangé, 2020/07/28
Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Peter Maydell, 2020/07/24