[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/16] linux-user: fix clock_nanosleep()
From: |
Richard Henderson |
Subject: |
Re: [PATCH v3 12/16] linux-user: fix clock_nanosleep() |
Date: |
Fri, 24 Jul 2020 11:24:24 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 7/23/20 11:45 PM, Alex Bennée wrote:
> From: Laurent Vivier <laurent@vivier.eu>
>
> If the call is interrupted by a signal handler, it fails with error EINTR
> and if "remain" is not NULL and "flags" is not TIMER_ABSTIME, it returns
> the remaining unslept time in "remain".
>
> Update linux-user to not overwrite the "remain" structure if there is no
> error.
>
> Found with "make check-tcg", linux-test fails on nanosleep test:
>
> TEST linux-test on x86_64
> .../tests/tcg/multiarch/linux-test.c:242: nanosleep
>
> Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20200722174612.2917566-2-laurent@vivier.eu>
> ---
> linux-user/syscall.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH v3 06/16] accel/tcg: better handle memory constrained systems, (continued)
- [PATCH v3 06/16] accel/tcg: better handle memory constrained systems, Alex Bennée, 2020/07/24
- [PATCH v3 05/16] util/oslib-win32: add qemu_get_host_physmem implementation, Alex Bennée, 2020/07/24
- [PATCH v3 08/16] linux-user: don't use MAP_FIXED in pgd_find_hole_fallback, Alex Bennée, 2020/07/24
- [PATCH v3 10/16] tests/docker: fix binfmt_misc image building, Alex Bennée, 2020/07/24
- [PATCH v3 07/16] target/i386: floatx80: avoid compound literals in static initializers, Alex Bennée, 2020/07/24
- [PATCH v3 12/16] linux-user: fix clock_nanosleep(), Alex Bennée, 2020/07/24
- Re: [PATCH v3 12/16] linux-user: fix clock_nanosleep(),
Richard Henderson <=
- [PATCH v3 16/16] tests/vm: add shutdown timeout in basevm.py, Alex Bennée, 2020/07/24
- [PATCH v3 11/16] tests/docker: add support for DEB_KEYRING, Alex Bennée, 2020/07/24
- [PATCH v3 14/16] python/qemu: Cleanup changes to ConsoleSocket, Alex Bennée, 2020/07/24
- [PATCH v3 09/16] tests/docker: fix update command due to python3 str/bytes distinction, Alex Bennée, 2020/07/24
- [PATCH v3 13/16] linux-user, ppc: fix clock_nanosleep() for linux-user-ppc, Alex Bennée, 2020/07/24
- [PATCH v3 15/16] python/qemu: Change ConsoleSocket to optionally drain socket., Alex Bennée, 2020/07/24