[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/4] cirrus.yml: Compile macOS with -Werror
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 3/4] cirrus.yml: Compile macOS with -Werror |
Date: |
Tue, 28 Jul 2020 11:04:36 +0100 |
User-agent: |
Mutt/1.14.5 (2020-06-23) |
On Tue, Jul 28, 2020 at 09:44:04AM +0200, Thomas Huth wrote:
> Compiler warnings currently go unnoticed in our macOS builds, since -Werror
> is only enabled for Linux and MinGW builds by default. So let's enable them
> here now, too.
> Unfortunately, the sasl header is marked as deprecated in the macOS headers
> and thus generates a lot of deprecation warnings. Thus we have to also use
> -Wno-error=deprecated-declarations to be able to compile the code here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .cirrus.yml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|