Re: [PATCH v5 7/7] Makefile: Ship the generic platform bios ELF images for RISC-V

[Alistair Francis]

On Tue, Jul 28, 2020 at 8:52 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Alistair,
>
> On Tue, Jul 28, 2020 at 11:37 PM Alistair Francis <alistair23@gmail.com> 
> wrote:
> >
> > On Wed, Jul 15, 2020 at 11:01 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > From: Bin Meng <bin.meng@windriver.com>
> > >
> > > At present only the generic platform fw_dynamic bios BIN images
> > > are included in the 'make install' target for 'virt' and 'sifive_u'
> > > machines. This updates the install blob list to include ELF images
> > > which are needed by the 'spike' machine.
> > >
> > > Signed-off-by: Bin Meng <bin.meng@windriver.com>
> >
> > This commit should be squashed into patch 5.
>
> I actually considered this before, and I was thinking that patch 5 is
> only for "fixing" the missing binaries for Spike machine, and this
> patch addresses the "make install" issue, hence separate patch.

Patch 5 creates the issue though, so I think it is worth fixing there.

>
> >
> > Do you want me to do that when applying?
>
> Sure, please do then if you feel this is the correct way.

This series still has regressions, so when you send a new version
please squash this patch.

Alistair

>
> Regards,
> Bin