[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/7] spice: Make spice a module configuration

From: Gerd Hoffmann
Subject: Re: [PATCH 4/7] spice: Make spice a module configuration
Date: Tue, 4 Aug 2020 08:26:47 +0200

On Thu, Jul 23, 2020 at 07:46:12PM +0200, Christophe de Dinechin wrote:
> This commit changes the spice configuration 'm' by default, and moves
> the spice components to obj-m variables. It is sufficient to build
> without modules enable, but does not link correctly yet, since no
> shims have been created for the missing functions yet.

So it breaks the modular build?  Don't do that, it is bad for bisecting.
I guess this patch should simply come later in the patch series.

I can see that it is useful to have it here for development, so you
easily find all the places which need a fixup, but for merging the
patches should be reordered.

take care,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]