[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 08/20] multi-process: Initialize message handler in remote
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v8 08/20] multi-process: Initialize message handler in remote device |
Date: |
Tue, 4 Aug 2020 13:58:37 +0100 |
On Fri, Jul 31, 2020 at 02:20:15PM -0400, Jagannathan Raman wrote:
> +gboolean mpqemu_process_msg(QIOChannel *ioc, GIOCondition cond,
> + gpointer opaque)
> +{
> + PCIDevice *pci_dev = (PCIDevice *)opaque;
> + Error *local_err = NULL;
> + MPQemuMsg msg = { 0 };
> +
> + if (cond & G_IO_HUP) {
> + qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
> + return FALSE;
> + }
> +
> + if (cond & (G_IO_ERR | G_IO_NVAL)) {
> + error_report("Error %d while processing message from proxy \
> + in remote process pid=%d", errno, getpid());
String literals don't wrap with backslash in C. Please use:
"Error %d while processing message from proxy "
"in remote process pid=%d", ...
instead.
> + return FALSE;
> + }
> +
> + mpqemu_msg_recv(&msg, ioc, &local_err);
> + if (local_err) {
> + goto exit;
> + }
> +
> + if (!mpqemu_msg_valid(&msg)) {
> + error_report("Received invalid message from proxy \
> + in remote process pid=%d", getpid());
Same here.
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v8 08/20] multi-process: Initialize message handler in remote device,
Stefan Hajnoczi <=