Re: [PATCH-for-5.1 v2 2/2] stubs: Remove qemu_notify_event()

[Thomas Huth]

On 05/08/2020 11.59, Philippe Mathieu-Daudé wrote:
> On 8/5/20 11:42 AM, Philippe Mathieu-Daudé wrote:
>> On 8/5/20 10:55 AM, Philippe Mathieu-Daudé wrote:
>>> We don't need the qemu_notify_event() stub anymore.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> ---
>>>  stubs/cpu-get-icount.c | 2 +-
>>>  stubs/notify-event.c   | 6 ------
>>>  stubs/Makefile.objs    | 1 -
>>>  3 files changed, 1 insertion(+), 8 deletions(-)
>>>  delete mode 100644 stubs/notify-event.c
>>>
>>> diff --git a/stubs/cpu-get-icount.c b/stubs/cpu-get-icount.c
>>> index b35f844638..8962dfd71f 100644
>>> --- a/stubs/cpu-get-icount.c
>>> +++ b/stubs/cpu-get-icount.c
>>> @@ -17,5 +17,5 @@ int64_t cpu_get_icount_raw(void)
>>>  
>>>  void qemu_timer_notify_cb(void *opaque, QEMUClockType type)
>>>  {
>>> -    qemu_notify_event();
>>> +    abort();
>>
>> This abort makes iotest 077 fail.
>> I think I'll simply repost without it.
> 
> I don't understand what from 077 trigger this callback, but
> I confirm doing nothing is safe, ...
> 
>>
>>>  }
>>> diff --git a/stubs/notify-event.c b/stubs/notify-event.c
>>> deleted file mode 100644
>>> index 827bb52d1a..0000000000
>>> --- a/stubs/notify-event.c
>>> +++ /dev/null
>>> @@ -1,6 +0,0 @@
>>> -#include "qemu/osdep.h"
>>> -#include "qemu/main-loop.h"
>>> -
>>> -void qemu_notify_event(void)
>>> -{
> 
> ... as this is the current behavior.

But could we maybe end up in a scenario, where the stub from
stubs/cpu-get-icount.c is used, which then calls the real implementation
of qemu_notify_event() in main-loop.c ?

 Thomas