[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 0/2] add new options to set smbios type 4 fields

From: Ying Fang
Subject: Re: [PATCH v5 0/2] add new options to set smbios type 4 fields
Date: Thu, 6 Aug 2020 14:58:14 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

On 8/6/2020 2:01 PM, Michael S. Tsirkin wrote:
On Thu, Aug 06, 2020 at 11:56:32AM +0800, Ying Fang wrote:
From: fangying <fangying1@huawei.com>

Hi, this patchset was previously posted by my teamate Heyi Guo several
months ago, however we missed the merge window. It is reposted here to
make it an end. Thanks.

Thanks, I will tag it for after the release.
Pls ping me after the release to make sure I don't drop it by mistake.

Yes, I will do that. Hope it won't be missed this time.

Patch description:
Common VM users sometimes care about CPU speed, so we add two new
options to allow VM vendors to present CPU speed to their users.
Normally these information can be fetched from host smbios.

Strictly speaking, the "max speed" and "current speed" in type 4
are not really for the max speed and current speed of processor, for
"max speed" identifies a capability of the system, and "current speed"
identifies the processor's speed at boot (see smbios spec), but some
applications do not tell the differences.


v4 -> v5:
- Rebase patch for lastest upstream

v3 -> v4:
- Fix the default value when not specifying "-smbios type=4" option;
it would be 0 instead of 2000 in previous versions
- Use uint64_t type to check value overflow
- Add test case to check smbios type 4 CPU speed
- v4 https://patchwork.kernel.org/cover/11444635/

v2 -> v3:
- Refine comments per Igor's suggestion.

v1 -> v2:
- change "_" in option names to "-"
- check if option value is too large to fit in SMBIOS type 4 speed

Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>

Ying Fang (2):
   hw/smbios: add options for type 4 max-speed and current-speed
   tests/bios-tables-test: add smbios cpu speed test

  hw/smbios/smbios.c       | 36 ++++++++++++++++++++++++++++++----
  qemu-options.hx          |  2 +-
  tests/bios-tables-test.c | 42 ++++++++++++++++++++++++++++++++++++++++
  3 files changed, 75 insertions(+), 5 deletions(-)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]