Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

[Jiaxun Yang]

在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道:
> We only implement the Index[Store/Load]Tag from the 'cache' opcode.
> Instead of ignoring the other cache operations, report them as
> unimplemented.

Hmm, I don't think we have anything to do with Invalidate/Writeback etc. 
opcodes
in QEMU. Why do we log this?

Thanks.

- Jiaxun

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   target/mips/op_helper.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c
> index 9552b280e0..7f87e57c8e 100644
> --- a/target/mips/op_helper.c
> +++ b/target/mips/op_helper.c
> @@ -1583,6 +1583,8 @@ void helper_cache(CPUMIPSState *env, target_ulong addr, 
> uint32_t op)
>           /* Index Load Tag */
>           memory_region_dispatch_read(env->itc_tag, index, &env->CP0_TagLo,
>                                       MO_64, MEMTXATTRS_UNSPECIFIED);
> +    } else {
> +        qemu_log_mask(LOG_UNIMP, "cache %u\n", op);
>       }
>   #endif
>   }