[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 135/147] meson: sphinx-build

From: Paolo Bonzini
Subject: Re: [PATCH 135/147] meson: sphinx-build
Date: Mon, 10 Aug 2020 21:31:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 10/08/20 21:21, Peter Maydell wrote:
>> Yes, because the Makefile's approach is not maintainable in my opinion;
>> *.rst.inc files were already not included in the Makefile.  I'll look
>> into using a Sphinx extension to produce a dependency file.
> Yeah, agreed that the makefile approach isn't great. (It lists
> some .rst.inc files but we added more without updating the
> dependencies, I think.)
> If Sphinx can be persuaded to output a dependency file that
> would certainly be the nicest approach; I hadn't thought
> of trying that.

It should be possible and probably not too hard once I figure out how
Sphinx events work.  It's a fair request since build_always_stale is
inferior and Meson requires no particular magic to include the depfile.
 Maybe that will win you over. :)

I can also leave out sphinx from the initial conversion.

> It would be nice to note in the commit messages where the
> conversion has made this kind of "we're going to do it a
> different way" design decision rather than just being
> a translation of the makefile logic into Meson.

Yes, I'll do that for the final version (to be posted Friday or next

Thanks for running these initial test, it looks encouraging.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]