[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v5 04/20] qapi/qapi-schema.json: Put headers in their own doc-com

From: Peter Maydell
Subject: [PATCH v5 04/20] qapi/qapi-schema.json: Put headers in their own doc-comment blocks
Date: Mon, 10 Aug 2020 20:50:03 +0100

Our current QAPI doc-comment markup allows section headers
(introduced with a leading '=' or '==') anywhere in any documentation
comment.  This works for texinfo because the texi generator simply
prints a texinfo heading directive at that point in the output
stream.  For rST generation, since we're assembling a tree of
docutils nodes, this is awkward because a new section implies
starting a new section node at the top level of the tree and
generating text into there.

New section headings in the middle of the documentation of a command
or event would be pretty nonsensical, and in fact we only ever output
new headings using 'freeform' doc comment blocks whose only content
is the single line of the heading, with two exceptions, which are in
the introductory freeform-doc-block at the top of

Split that doc-comment up so that the heading lines are in their own
doc-comment.  This will allow us to tighten the specification to
insist that heading lines are always standalone, rather than
requiring the rST document generator to look at every line in a doc
comment block and handle headings in odd places.

This change makes no difference to the generated texi.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
 qapi/qapi-schema.json | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/qapi/qapi-schema.json b/qapi/qapi-schema.json
index f03ff91ceb5..5fc0771eb04 100644
--- a/qapi/qapi-schema.json
+++ b/qapi/qapi-schema.json
@@ -2,7 +2,9 @@
 # vim: filetype=python
 # = Introduction
 # This document describes all commands currently supported by QMP.
 # Most of the time their usage is exactly the same as in the user Monitor, this
@@ -26,9 +28,13 @@
 # Please, refer to the QMP specification (docs/interop/qmp-spec.txt) for
 # detailed information on the Server command and response formats.
 # = Stability Considerations
 # The current QMP command set (described in this file) may be useful for a
 # number of use cases, however it's limited and several commands have bad
 # defined semantics, specially with regard to command completion.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]