Re: [RFC v4 11/14] hvf: remove hvf specific functions from global includes

[Philippe Mathieu-Daudé]

On 8/12/20 4:49 PM, Claudio Fontana wrote:
> On 8/11/20 11:03 PM, Claudio Fontana wrote:
>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>> ---
>>  accel/stubs/Makefile.objs  |  1 -
>>  accel/stubs/hvf-stub.c     | 30 ------------------------------
>>  include/sysemu/hvf.h       |  8 --------
>>  target/i386/hvf/hvf-cpus.c |  1 +
>>  target/i386/hvf/hvf-int.h  | 24 ++++++++++++++++++++++++
>>  target/i386/hvf/hvf.c      |  1 +
>>  target/i386/hvf/x86hvf.c   |  2 ++
>>  target/i386/hvf/x86hvf.h   |  1 -
>>  8 files changed, 28 insertions(+), 40 deletions(-)
>>  delete mode 100644 accel/stubs/hvf-stub.c
>>  create mode 100644 target/i386/hvf/hvf-int.h
[...]
>> --- a/target/i386/hvf/hvf-cpus.c
>> +++ b/target/i386/hvf/hvf-cpus.c
>> @@ -55,6 +55,7 @@
>>  #include "target/i386/cpu.h"
>>  #include "qemu/guest-random.h"
>>  
>> +#include "hvf-int.h"
>>  #include "hvf-cpus.h"
>>  
>>  /*
>> diff --git a/target/i386/hvf/hvf-int.h b/target/i386/hvf/hvf-int.h
>> new file mode 100644
>> index 0000000000..50d108ca08
>> --- /dev/null
>> +++ b/target/i386/hvf/hvf-int.h
> 
> 
> Hmm maybe I could avoid creating a new header file,
> and just cram these functions in hvf-cpus.h ?

Yes it seems better (similar rename with the other accelerators).

> 
> Any thoughts?
> 
> Thanks,
> 
> Claudio