[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] block: Raise an error when backing file parameter is an e
Re: [PATCH v2] block: Raise an error when backing file parameter is an empty string
Thu, 13 Aug 2020 07:59:55 -0500
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0
On 8/12/20 1:58 AM, Kevin Wolf wrote:
This looks like a test case that would be better served by not using
QMPTestCase, but just printing the qemu-img output and having the
message compared against the reference output.
In fact, there is already 049 for testing some qemu-img create options
and we could just add a line there (or multiple lines to cover other
backing file related error cases, too).
Putting it there would both simplify the test code and keep 298 free for
the other series.
None of the above is really a reason to reject the patch. I guess this
is more of a "are you sure? (y/n)" before I apply it. :-)
Hi Kevin! Thanks for the review :-)
I think it'd be best for my own edification to address your comments
here instead of applying this now. I'll send a v3.