[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks
Date: Thu, 13 Aug 2020 17:01:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 8/13/20 3:43 PM, P J P wrote:
> +-- On Thu, 13 Aug 2020, David Gibson wrote --+
> | The overall idea seems fine.  Looks like we could avoid a fair bit of 
> | boilerplate - and slightly reduce our binary size - by introducing a global 
> | unimplemented_write() function.

IIRC in v2 or v3 it was mentioned each device has to be handled
differently, as it behaves differently, it sits on a particular bus, and
so on. So the preferred way is to have a device-specific handler.

(This explains v4 and why these patches took so long).

> * You mean for after this assert(3) in memory_region_init_io change is 
> merged?  
>   This series attempts to define all missing r/w calls.
> * There are also unassigned_mem_read/write functions, maybe those can be 
>   reused?
> Thank you.
> --
> Prasad J Pandit / Red Hat Product Security Team
> 8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D

reply via email to

[Prev in Thread] Current Thread [Next in Thread]