[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 2/3] target/mips/op_helper: Document Invalidate/Writeb
|
From: |
Richard Henderson |
|
Subject: |
Re: [RFC PATCH v2 2/3] target/mips/op_helper: Document Invalidate/Writeback opcodes as no-op |
|
Date: |
Thu, 13 Aug 2020 12:51:11 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/13/20 11:15 AM, Philippe Mathieu-Daudé wrote:
> switch (cache_operation) {
> - case 0b010:
> - /* Index Store Tag */
> + case 0b010: /* Index Store Tag */
> memory_region_dispatch_write(env->itc_tag, index, env->CP0_TagLo,
> MO_64, MEMTXATTRS_UNSPECIFIED);
> break;
> - case 0b001:
> - /* Index Load Tag */
> + case 0b001: /* Index Load Tag */
> memory_region_dispatch_read(env->itc_tag, index, &env->CP0_TagLo,
> MO_64, MEMTXATTRS_UNSPECIFIED);
> break;
Merge these lines back to patch 1. With that, both 1/ and 2/,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~