qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 22/41] can_emu: Delete macros for non-existing typedef


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 22/41] can_emu: Delete macros for non-existing typedef
Date: Fri, 14 Aug 2020 20:03:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 8/14/20 12:26 AM, Eduardo Habkost wrote:
> CanBusClass doesn't exist.  This will break when we automatically
> convert the code to use OBJECT_DEFINE_TYPE().  Delete the macros
> that reference the non-existing typedef.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  include/net/can_emu.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/net/can_emu.h b/include/net/can_emu.h
> index fce9770928..7e90fd8a45 100644
> --- a/include/net/can_emu.h
> +++ b/include/net/can_emu.h
> @@ -100,10 +100,6 @@ struct CanBusClientState {
>  };
>  
>  #define TYPE_CAN_BUS "can-bus"
> -#define CAN_BUS_CLASS(klass) \
> -     OBJECT_CLASS_CHECK(CanBusClass, (klass), TYPE_CAN_BUS)
> -#define CAN_BUS_GET_CLASS(obj) \
> -     OBJECT_GET_CLASS(CanBusClass, (obj), TYPE_CAN_BUS)
>  #define CAN_BUS(obj) \
>       OBJECT_CHECK(CanBusState, (obj), TYPE_CAN_BUS)
>  
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]