qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 02/22] qapi: Create block-export module


From: Max Reitz
Subject: Re: [RFC PATCH 02/22] qapi: Create block-export module
Date: Mon, 17 Aug 2020 10:50:10 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 13.08.20 18:29, Kevin Wolf wrote:
> Move all block export related types and commands from block-core to the
> new QAPI module block-export.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  qapi/block-core.json                 | 166 --------------------------
>  qapi/block-export.json               | 172 +++++++++++++++++++++++++++
>  qapi/qapi-schema.json                |   1 +
>  include/block/nbd.h                  |   2 +-
>  block/monitor/block-hmp-cmds.c       |   1 +
>  blockdev-nbd.c                       |   2 +-
>  qemu-storage-daemon.c                |   2 +-
>  qapi/Makefile.objs                   |   5 +-
>  storage-daemon/qapi/qapi-schema.json |   1 +
>  9 files changed, 181 insertions(+), 171 deletions(-)
>  create mode 100644 qapi/block-export.json

[...]

> diff --git a/qapi/block-export.json b/qapi/block-export.json
> new file mode 100644
> index 0000000000..62f4938e83
> --- /dev/null
> +++ b/qapi/block-export.json
> @@ -0,0 +1,172 @@

There should probably be a filetype modeline here (not trying to get
into any hornets’ nest here, but... :)).

With that:

Reviewed-by: Max Reitz <mreitz@redhat.com>

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]