Re: [RFC PATCH 02/22] qapi: Create block-export module

[Eric Blake]

On 8/13/20 11:29 AM, Kevin Wolf wrote:
> Move all block export related types and commands from block-core to the
> new QAPI module block-export.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---

> +++ b/qapi/block-export.json
> @@ -0,0 +1,172 @@
> +##
> +# == Block device exports
> +##
> +
> +{ 'include': 'sockets.json' }
> +

> +++ b/qapi/Makefile.objs
> @@ -5,7 +5,8 @@ util-obj-y += opts-visitor.o qapi-clone-visitor.o
>   util-obj-y += qmp-event.o
>   util-obj-y += qapi-util.o
>   
> -QAPI_COMMON_MODULES = audio authz block-core block char common control crypto
> +QAPI_COMMON_MODULES = audio authz block-core block-export block char common
> +QAPI_COMMON_MODULES += control crypto

I don't know what Paolo's Meson conversion will affect here, but even if 
it changes how this hunk looks, the intent is obvious.

Looks like a straightforward refactoring.  I agree with Max's comment on 
the missing modeline, but that doesn't stop me from:

Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org