Re: [PATCH] tests/docker: add liburing-devel to the Fedora image

[Philippe Mathieu-Daudé]

On 8/21/20 6:54 PM, Stefano Garzarella wrote:
> Install liburing-devel dependencies to get better coverage on
> io-uring stuff (block/io_uring.c and util/fdmon-io_uring.c).
> 
> Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>  tests/docker/dockerfiles/fedora.docker | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/docker/dockerfiles/fedora.docker 
> b/tests/docker/dockerfiles/fedora.docker
> index 70b6186bd3..9650d324fa 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -38,6 +38,7 @@ ENV PACKAGES \
>      libssh-devel \
>      libubsan \
>      libudev-devel \
> +    liburing-devel \
>      libusbx-devel \
>      libxml2-devel \
>      libzstd-devel \
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

../util/fdmon-io_uring.c:106:17: error: address argument to atomic
operation must be a pointer to _Atomic type ('unsigned int *' invalid)
    old_flags = atomic_fetch_or(&node->flags, FDMON_IO_URING_PENDING |
flags);
                ^               ~~~~~~~~~~~~
/usr/lib64/clang/10.0.0/include/stdatomic.h:138:42: note: expanded from
macro 'atomic_fetch_or'
#define atomic_fetch_or(object, operand) __c11_atomic_fetch_or(object,
operand, __ATOMIC_SEQ_CST)
                                         ^                     ~~~~~~
../util/fdmon-io_uring.c:130:14: error: address argument to atomic
operation must be a pointer to _Atomic type ('unsigned int *' invalid)
    *flags = atomic_fetch_and(&node->flags, ~(FDMON_IO_URING_PENDING |
             ^                ~~~~~~~~~~~~

Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>