Re: [PATCH 4/5] meson: !/bin/sh are msys2 friendly.

[Yonggang Luo]

Hi, works, msys2 sh compiled and run

On Tue, Aug 25, 2020 at 4:59 PM Daniel P. Berrangé <berrange@redhat.com> wrote:

On Tue, Aug 25, 2020 at 04:34:59PM +0800, luoyonggang@gmail.com wrote:
> From: Yonggang Luo <luoyonggang@gmail.com>
>
> ---
>  scripts/undefsym.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/undefsym.sh b/scripts/undefsym.sh
> index b9ec332e95..8189308b2c 100755
> --- a/scripts/undefsym.sh
> +++ b/scripts/undefsym.sh
> @@ -1,4 +1,4 @@
> -#! /usr/bin/env bash
> +#!/bin/sh

Does this script actually work on non-bash shells ?  If not, then this
change will likely break on plaforms where /bin/sh is not bash.

> 
>  # Before a shared module's DSO is produced, a static library is built for it
>  # and passed to this script.  The script generates -Wl,-u options to force
> --
> 2.27.0.windows.1
>
>

Regards,
Daniel
--
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--

         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo