Re: [PATCH 5/5] meson: add NSIS building

[Daniel P . Berrangé]

On Tue, Aug 25, 2020 at 07:04:09PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  Makefile        | 56 -----------------------------------------------
>  meson.build     | 24 ++++++++++++++++++++
>  scripts/nsis.sh | 58 +++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 82 insertions(+), 56 deletions(-)
>  create mode 100755 scripts/nsis.sh

I feel like one of the bug improvements of Meson over a traditional
configure+make type approach is that we get much improved platform
portability by default in the build system, largely for free from
Meson and in turn Python.

With this in mind, I think that as a general goal, we should strive
to eliminate any and all use of shell in the build system, standardizing
on Python for any helper programs we need to run from Meson.

This is a verbose way of saying I think you should create a
nsis.py, not nsis.sh, to avoid the inherant portability problems of
shell that hit us over and over and over again.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|