[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2 |
Date: |
Wed, 26 Aug 2020 09:22:45 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Wed, Aug 26, 2020 at 08:48:22AM +0200, Paolo Bonzini wrote:
> On Tue, Aug 25, 2020 at 11:38 PM Mark Cave-Ayland
> <mark.cave-ayland@ilande.co.uk> wrote:
> > Marc-André had a query about why this is marked as a system include,
> > however I can
> > confirm that it fixes the missing "SDL.h" issue during build.
>
> It was marked as a system include in an attempt to work around the SDL
> 2.0.8 bug that requires -Wno-undef. In general we enable lots of
> warnings and sometimes they trip dependencies, so using include_type:
> 'system' in principle makes sense. But if it doesn't work with
> Windows, it's not a regression to remove it.
SDL code is isolated to just a couple of files, so if we nede to squelch
a -Wno-undef warning, we can just use pragma push/pop to disable the
warning selectively in the code.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 2/4] meson: fixes relpath may fail on win32., (continued)
- [PATCH 2/4] meson: fixes relpath may fail on win32., luoyonggang, 2020/08/25
- [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2, luoyonggang, 2020/08/25
- [PATCH 4/4] configure: Fix include and linkage issue on msys2, luoyonggang, 2020/08/25
- [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja, luoyonggang, 2020/08/25
- [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2, luoyonggang, 2020/08/25
[PATCH 4/4] configure: Fix include and linkage issue on msys2, luoyonggang, 2020/08/25
Re: [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja, Mark Cave-Ayland, 2020/08/25
Re: [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja, Eric Blake, 2020/08/25