[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 08/12] migration/dirtyrate: skip sampling ramblock with si
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH v5 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE |
Date: |
Wed, 26 Aug 2020 17:54:25 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
* Chuan Zheng (zhengchuan@huawei.com) wrote:
> In order to sample real RAM, skip ramblock with size below MIN_RAMBLOCK_SIZE
> which is set as 128M.
>
> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
> ---
> migration/dirtyrate.c | 24 ++++++++++++++++++++++++
> migration/dirtyrate.h | 10 ++++++++++
> 2 files changed, 34 insertions(+)
>
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index 050270d..bd398b7 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -173,6 +173,24 @@ alloc_ramblock_dirty_info(int *block_index,
> return block_dinfo;
> }
>
> +static int skip_sample_ramblock(RAMBlock *block)
> +{
> + int64_t ramblock_size;
> +
> + /* ramblock size in MB */
> + ramblock_size = qemu_ram_get_used_length(block) >>
> DIRTYRATE_PAGE_SHIFT_MB;
> +
> + /*
> + * Consider ramblock with size larger than 128M is what we
> + * want to sample.
> + */
> + if (ramblock_size < MIN_RAMBLOCK_SIZE) {
> + return -1;
> + }
This seems way too complicated for:
if (qemu_ram_get_used_length(block) < (MIN_RAMBLOCK_SIZE << 10)) {
return -1;
}
return 0;
(even easier if it just returned bool from the comparison)
Dave
> + return 0;
> +}
> +
> static int record_ramblock_hash_info(struct RamblockDirtyInfo **block_dinfo,
> struct DirtyRateConfig config,
> int *block_index)
> @@ -183,6 +201,9 @@ static int record_ramblock_hash_info(struct
> RamblockDirtyInfo **block_dinfo,
> int index = 0;
>
> RAMBLOCK_FOREACH_MIGRATABLE(block) {
> + if (skip_sample_ramblock(block) < 0) {
> + continue;
> + }
> dinfo = alloc_ramblock_dirty_info(&index, dinfo);
> if (dinfo == NULL) {
> return -1;
> @@ -249,6 +270,9 @@ static int compare_page_hash_info(struct
> RamblockDirtyInfo *info,
> RAMBlock *block = NULL;
>
> RAMBLOCK_FOREACH_MIGRATABLE(block) {
> + if (skip_sample_ramblock(block) < 0) {
> + continue;
> + }
> block_dinfo = NULL;
> if (!find_page_matched(block, info, block_index + 1, &block_dinfo)) {
> continue;
> diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h
> index e3adead..600bceb 100644
> --- a/migration/dirtyrate.h
> +++ b/migration/dirtyrate.h
> @@ -35,10 +35,20 @@
> #define DIRTYRATE_PAGE_SHIFT_KB 12
>
> /*
> + * Sample page size MB shift
> + */
> +#define DIRTYRATE_PAGE_SHIFT_MB 20
> +
> +/*
> * Sample page size 1G shift
> */
> #define DIRTYRATE_PAGE_SHIFT_GB 30
>
> +/*
> + * minimum ramblock size to sampled
> + */
> +#define MIN_RAMBLOCK_SIZE 128
> +
> /* Take 1s as default for calculation duration */
> #define DEFAULT_FETCH_DIRTYRATE_TIME_SEC 1
>
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- Re: [PATCH v5 01/12] migration/dirtyrate: setup up query-dirtyrate framwork, (continued)
- [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info, Chuan Zheng, 2020/08/24
- [PATCH v5 04/12] migration/dirtyrate: Add dirtyrate statistics series functions, Chuan Zheng, 2020/08/24
- [PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page, Chuan Zheng, 2020/08/24
- [PATCH v5 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status, Chuan Zheng, 2020/08/24
- [PATCH v5 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE, Chuan Zheng, 2020/08/24
- Re: [PATCH v5 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE,
Dr. David Alan Gilbert <=
- [PATCH v5 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function, Chuan Zheng, 2020/08/24
- [PATCH v5 09/12] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period(), Chuan Zheng, 2020/08/24
- [PATCH v5 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function, Chuan Zheng, 2020/08/24
- [PATCH v5 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h, Chuan Zheng, 2020/08/24
- [PATCH v5 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page, Chuan Zheng, 2020/08/24
- [PATCH v5 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug, Chuan Zheng, 2020/08/24