[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL v2 00/12] target-hppa fixes pull request v2

From: Peter Maydell
Subject: Re: [PULL v2 00/12] target-hppa fixes pull request v2
Date: Wed, 26 Aug 2020 21:21:55 +0100

On Mon, 10 Aug 2020 at 14:24, Helge Deller <deller@gmx.de> wrote:
> Please pull from
>     https://github.com/hdeller/qemu-hppa.git target-hppa
> to fix those bugs in target-hppa:
> * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian
> * Fix the SeaBIOS-hppa firmware to boot NetBSD again
> * Fix many artist framebuffer out-of-bounds accesses as found by Alexander 
> Bulekov
> * Fix artist memory access bugs due to commit 5d971f9e6725 ("memory: Revert
>   "memory: accept mismatching sizes in memory_region_access_valid")
> * Fix various artist screen updates when running dtwm on HP-UX
> In addition the SeaBIOS-hppa firmware now includes a version check to prevent
> starting when it's incompatible to the emulated qemu hardware.

Hi; this (via the tag target-hppa-v2-pull-request) has
a format string issue on windows and 32bit:

In file included from ../../hw/hppa/lasi.c:14:0:
../../hw/hppa/lasi.c: In function 'lasi_chip_write_with_attrs':
../../hw/hppa/lasi.c:177:17: error: format '%lx' expects argument of
type 'long unsigned int', but argument 2 has type 'uint64_t {aka long
long unsigned int}' [-Werror=format=]
                 "LASI: tried to set invalid %lx IMR value.\n", val);
/home/peter.maydell/qemu/include/qemu/log.h:120:22: note: in
definition of macro 'qemu_log_mask'
             qemu_log(FMT, ## __VA_ARGS__);              \

PS: also I've just noticed that your pullreq email doesn't
have the standard git request-pull cover letter phrasing;
if you don't use that then my email filters will not notice
your pullreqs.

https://wiki.qemu.org/Contribute/SubmitAPullRequest is worth
reading if you haven't found it already.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]