qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 11/18] meson: Add U2F key to meson


From: Paolo Bonzini
Subject: Re: [PULL 11/18] meson: Add U2F key to meson
Date: Fri, 28 Aug 2020 12:48:53 +0200

Il ven 28 ago 2020, 10:08 Gerd Hoffmann <kraxel@redhat.com> ha scritto:

+u2f = dependency('u2f-emu', required: get_option('u2f'), static: enable_static,
+                 include_type: 'system')
+if u2f.found()
+  u2f = declare_dependency(dependencies: u2f)
+endif

Better:

u2f = not_found
if have_system
  u2f = dependency('u2f-emu', required: get_option('u2f'), static: enable_static)
endif

The declare_dependency afterwards is not needed.

  +config_host_data.set('CONFIG_U2F', u2f.found())

Not needed is there no #ifdef CONFIG_U2F.

Paolo 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]