Re: [RFC v4 65/70] target/riscv: add "set round to odd" rounding mode helper function

[Richard Henderson]

On 8/17/20 1:49 AM, frank.chang@sifive.com wrote:
> From: Frank Chang <frank.chang@sifive.com>
> 
> helper_set_rounding_mode() is responsible for SIGILL, and "round to odd"
> should be an interface private to translation, so add a new independent
> helper_set_rod_rounding_mode().
> 
> Signed-off-by: Frank Chang <frank.chang@sifive.com>
> ---
>  target/riscv/fpu_helper.c | 5 +++++
>  target/riscv/helper.h     | 1 +
>  target/riscv/internals.h  | 1 +
>  target/riscv/translate.c  | 5 +++++
>  4 files changed, 12 insertions(+)
...
> @@ -44,6 +44,7 @@ enum {
>      FRM_RUP = 3,    /* Round Up */
>      FRM_RMM = 4,    /* Round to Nearest, ties to Max Magnitude */
>      FRM_DYN = 7,    /* Dynamic rounding mode */
> +    FRM_ROD = 8,    /* Round to Odd */
>  };

This needs a comment, or a rename, to indicate that it is private to qemu.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~