[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/4] hw/misc/a9scu: Simplify setting MemoryRegionOps::valid field
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 2/4] hw/misc/a9scu: Simplify setting MemoryRegionOps::valid fields |
Date: |
Tue, 1 Sep 2020 16:40:58 +0200 |
Per the datasheet (DDI0407 r2p0):
"All SCU registers are byte accessible" and are 32-bit aligned.
Set MemoryRegionOps::valid min/max fields and simplify the write()
handler.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/misc/a9scu.c | 21 +++++----------------
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/hw/misc/a9scu.c b/hw/misc/a9scu.c
index 915f127761e..3f3dcc414fe 100644
--- a/hw/misc/a9scu.c
+++ b/hw/misc/a9scu.c
@@ -52,23 +52,8 @@ static void a9_scu_write(void *opaque, hwaddr offset,
uint64_t value, unsigned size)
{
A9SCUState *s = (A9SCUState *)opaque;
- uint32_t mask;
+ uint32_t mask = MAKE_64BIT_MASK(0, size * 8);
uint32_t shift;
- switch (size) {
- case 1:
- mask = 0xff;
- break;
- case 2:
- mask = 0xffff;
- break;
- case 4:
- mask = 0xffffffff;
- break;
- default:
- fprintf(stderr, "Invalid size %u in write to a9 scu register %x\n",
- size, (unsigned)offset);
- return;
- }
switch (offset) {
case 0x00: /* Control */
@@ -99,6 +84,10 @@ static void a9_scu_write(void *opaque, hwaddr offset,
static const MemoryRegionOps a9_scu_ops = {
.read = a9_scu_read,
.write = a9_scu_write,
+ .valid = {
+ .min_access_size = 1,
+ .max_access_size = 4,
+ },
.endianness = DEVICE_NATIVE_ENDIAN,
};
--
2.26.2
- [PATCH 0/4] hw/misc/a9scu: Verify CPU count is valid and simplify a bit, Philippe Mathieu-Daudé, 2020/09/01
- [PATCH 1/4] hw/misc/a9scu: Do not allow invalid CPU count, Philippe Mathieu-Daudé, 2020/09/01
- [PATCH 2/4] hw/misc/a9scu: Simplify setting MemoryRegionOps::valid fields,
Philippe Mathieu-Daudé <=
- [PATCH 3/4] hw/misc/a9scu: Simplify setting MemoryRegionOps::impl fields, Philippe Mathieu-Daudé, 2020/09/01
- [PATCH 4/4] hw/misc/a9scu: Report unimplemented accesses with qemu_log_mask(UNIMP), Philippe Mathieu-Daudé, 2020/09/01
- Re: [PATCH 0/4] hw/misc/a9scu: Verify CPU count is valid and simplify a bit, Richard Henderson, 2020/09/01
- Re: [PATCH 0/4] hw/misc/a9scu: Verify CPU count is valid and simplify a bit, Peter Maydell, 2020/09/07