Re: [PATCH 2/2] hw/core: Move hw_error() out of cpus.c

[Philippe Mathieu-Daudé]

On 9/2/20 6:02 PM, Thomas Huth wrote:
> On 02/09/2020 17.59, Philippe Mathieu-Daudé wrote:
>> On 9/2/20 5:38 PM, Richard Henderson wrote:
>>> On 9/1/20 11:37 PM, Thomas Huth wrote:
>>>> - Move the function as "static inline" into the header file
>>>>   instead - it's not so big, so an inline function should be
>>>>   ok here.
>>>
>>> stdarg and inline do not mix.
>>>
>>>> - Add a big fat warning comment to the header that this
>>>>   function should not be used for new code anymore.
>>>
>>> But certainly this.
>>
>> Will do, but this has been proven to not work well...
> 
> ... or add a warning to checkpatch.pl ?

This certainly works better :)

> 
>  Thomas
> 
>