qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 28/63] tusb6010: Rename TYPE_TUSB6010 to TYPE_TUSB


From: Eduardo Habkost
Subject: Re: [PATCH 28/63] tusb6010: Rename TYPE_TUSB6010 to TYPE_TUSB
Date: Thu, 3 Sep 2020 12:37:53 -0400

On Thu, Sep 03, 2020 at 02:56:20PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > This will make the type name constant consistent with the name of
> > the type checking macro.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: qemu-devel@nongnu.org
> > ---
> >  hw/usb/tusb6010.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/hw/usb/tusb6010.c b/hw/usb/tusb6010.c
> > index 2bee3ae59f..9b35c1d4b8 100644
> > --- a/hw/usb/tusb6010.c
> > +++ b/hw/usb/tusb6010.c
> > @@ -30,10 +30,10 @@
> >  #include "hw/sysbus.h"
> >  #include "qom/object.h"
> >  
> > -#define TYPE_TUSB6010 "tusb6010"
> > +#define TYPE_TUSB "tusb6010"
> 
> We are loosing information helpful to reviewers.
> Can we rename the type macro TUSB6010() instead?

We can.  I will do it instead.

-- 
Eduardo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]