[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson: fix qxl module build

From: Gerd Hoffmann
Subject: Re: [PATCH] meson: fix qxl module build
Date: Fri, 4 Sep 2020 10:12:40 +0200


>  if config_all_devices.has_key('CONFIG_QXL')
>    qxl_ss = ss.source_set()
> -  qxl_ss.add(when: 'CONFIG_QXL', if_true: files('qxl.c', 'qxl-logger.c', 
> 'qxl-render.c'))
> +  qxl_ss.add(files('qxl.c', 'qxl-logger.c', 'qxl-render.c'))
>    hw_display_modules += {'qxl': qxl_ss}
>  endif
> -softmmu_ss.add(when: 'CONFIG_QXL', if_true: files('qxl.c', 'qxl-logger.c', 
> 'qxl-render.c'))

Damn.  Turned out to not be that easy.  Modular builds work fine, but
with non-modular builds I have the problem that qxl_ss is merged into
softmmu_ss *unconditionally*.  So when building two targets, one with
qxl enabled (i386 for example) and one without pci support (avr for
example) I get missing symbols for pci+vga due to the attempt to link
qxl into avr-softmmu.

Any hints how to solve that one?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]