qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/8] i8254: Rename TYPE_I8254 to TYPE_ISA_PIT


From: Daniel P . Berrangé
Subject: Re: [PATCH 1/8] i8254: Rename TYPE_I8254 to TYPE_ISA_PIT
Date: Fri, 4 Sep 2020 09:44:13 +0100
User-agent: Mutt/1.14.6 (2020-07-11)

On Thu, Sep 03, 2020 at 02:01:21PM -0400, Eduardo Habkost wrote:
> This will make the type name constant consistent with the name of
> the QOM type ("isa-pit").
> 
> Suggested-by:  "Daniel P. Berrangé" <berrange@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 -> v2:
> * v1 subject was: "i8254: Rename TYPE_I8254 to TYPE_PIT"
> * Rename it to TYPE_ISA_PIT instead of TYPE_PIT,
>   to be consistent with the existing "isa-pit" type
>   name
> ---
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
>  include/hw/timer/i8254.h | 4 ++--
>  hw/timer/i8254.c         | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]