[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 6/7] block-stream: freeze link to base node during stream
From: |
Max Reitz |
Subject: |
Re: [PATCH v8 6/7] block-stream: freeze link to base node during stream job |
Date: |
Fri, 4 Sep 2020 15:21:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 28.08.20 18:52, Andrey Shinkevich wrote:
> To keep the base node unchanged during the block-stream operation,
> freeze it as the other part of the backing chain with the intermediate
> nodes related to the job.
> This patch revers the change made with the commit c624b015bf as the
> correct base file name and its format have to be written down to the
> QCOW2 header on the disk when the backing file is being changed after
> the stream job completes.
> This reversion incurs changes in the tests 030, 245 and discards the
> test 258 where concurrent stream/commit jobs are tested. When the link
> to a base node is frozen, the concurrent job cannot change the common
> backing chain.
>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> ---
> block/stream.c | 29 ++------
> tests/qemu-iotests/030 | 10 +--
> tests/qemu-iotests/245 | 2 +-
> tests/qemu-iotests/258 | 161
> ---------------------------------------------
> tests/qemu-iotests/258.out | 33 ----------
> 5 files changed, 14 insertions(+), 221 deletions(-)
> delete mode 100755 tests/qemu-iotests/258
> delete mode 100644 tests/qemu-iotests/258.out
Does this need to be in this series? (I’m not entirely sure, based on
what I can see in patch 7.)
When doing this, should we introduce a @bottom-node option alongside, so
that we can make all the tests that are deleted here pass still, just
with changes?
Max
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH v8 6/7] block-stream: freeze link to base node during stream job,
Max Reitz <=