[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 6/7] scripts/ci/gitlab-pipeline-status: use more descriptive exce
From: |
Cleber Rosa |
Subject: |
[PATCH 6/7] scripts/ci/gitlab-pipeline-status: use more descriptive exceptions |
Date: |
Fri, 4 Sep 2020 12:42:57 -0400 |
For two very different error conditions.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
scripts/ci/gitlab-pipeline-status | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/scripts/ci/gitlab-pipeline-status
b/scripts/ci/gitlab-pipeline-status
index ced488f27c..628150ce0b 100755
--- a/scripts/ci/gitlab-pipeline-status
+++ b/scripts/ci/gitlab-pipeline-status
@@ -23,6 +23,14 @@ import time
import sys
+class CommunicationFailure(Exception):
+ """Failed to communicate to gitlab.com APIs."""
+
+
+class NoPipelineFound(Exception):
+ """Communication is successfull but pipeline is not found."""
+
+
def get_local_branch_commit(branch='staging'):
"""
Returns the commit sha1 for the *local* branch named "staging"
@@ -50,14 +58,14 @@ def get_pipeline_status(project_id, commit_sha1):
connection.request('GET', url=url)
response = connection.getresponse()
if response.code != http.HTTPStatus.OK:
- raise ValueError("Failed to receive a successful response")
+ raise CommunicationFailure("Failed to receive a successful response")
json_response = json.loads(response.read())
# As far as I can tell, there should be only one pipeline for the same
# project + commit. If this assumption is false, we can add further
# filters to the url, such as username, and order_by.
if not json_response:
- raise ValueError("No pipeline found")
+ raise NoPipelineFound("No pipeline found")
return json_response[0]
--
2.25.4
- [PATCH 0/7] gitlab pipeline check/watch script improvements, Cleber Rosa, 2020/09/04
- [PATCH 2/7] scripts/ci/gitlab-pipeline-status: improve message regarding timeout, Cleber Rosa, 2020/09/04
- [PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines, Cleber Rosa, 2020/09/04
- [PATCH 6/7] scripts/ci/gitlab-pipeline-status: use more descriptive exceptions,
Cleber Rosa <=
- [PATCH 7/7] scripts/ci/gitlab-pipeline-status: wait for pipeline creation, Cleber Rosa, 2020/09/04
- [PATCH 4/7] scripts/ci/gitlab-pipeline-status: refactor parser creation, Cleber Rosa, 2020/09/04
- [PATCH 1/7] scripts/ci/gitlab-pipeline-status: make branch name configurable, Cleber Rosa, 2020/09/04
- [PATCH 5/7] scripts/ci/gitlab-pipeline-status: handle keyboard interrupts, Cleber Rosa, 2020/09/04