[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/17] hw/block/nvme: default request status to success
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 09/17] hw/block/nvme: default request status to success |
Date: |
Mon, 7 Sep 2020 04:17:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/4/20 4:19 PM, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Make the default request status NVME_SUCCESS so only error status codes
> has to be set.
Typo 'has' -> 'have'.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/block/nvme.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 3e32f39c7c1d..64c8f232e3ea 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -231,6 +231,7 @@ static void nvme_req_clear(NvmeRequest *req)
> {
> req->ns = NULL;
> memset(&req->cqe, 0x0, sizeof(req->cqe));
> + req->status = NVME_SUCCESS;
> }
>
> static void nvme_req_exit(NvmeRequest *req)
> @@ -547,8 +548,6 @@ static void nvme_process_aers(void *opaque)
> result->log_page = event->result.log_page;
> g_free(event);
>
> - req->status = NVME_SUCCESS;
> -
> trace_pci_nvme_aer_post_cqe(result->event_type, result->event_info,
> result->log_page);
>
> @@ -713,7 +712,6 @@ static void nvme_aio_cb(void *opaque, int ret)
>
> if (!ret) {
> block_acct_done(stats, acct);
> - req->status = NVME_SUCCESS;
> } else {
> uint16_t status;
>
>
- [PATCH 08/17] hw/block/nvme: refactor aio submission, (continued)
[PATCH 05/17] hw/block/nvme: add a lba to bytes helper, Klaus Jensen, 2020/09/04
[PATCH 07/17] hw/block/nvme: add symbolic command name to trace events, Klaus Jensen, 2020/09/04
[PATCH 10/17] hw/block/nvme: support multiple parallel aios per request, Klaus Jensen, 2020/09/04
[PATCH 09/17] hw/block/nvme: default request status to success, Klaus Jensen, 2020/09/04
- Re: [PATCH 09/17] hw/block/nvme: default request status to success,
Philippe Mathieu-Daudé <=
[PATCH 11/17] hw/block/nvme: harden cmb access, Klaus Jensen, 2020/09/04
[PATCH 16/17] pci: allocate pci id for nvme, Klaus Jensen, 2020/09/04
[PATCH 13/17] hw/block/nvme: add support for sgl bit bucket descriptor, Klaus Jensen, 2020/09/04
[PATCH 15/17] hw/block/nvme: support multiple namespaces, Klaus Jensen, 2020/09/04
[PATCH 14/17] hw/block/nvme: refactor identify active namespace id list, Klaus Jensen, 2020/09/04
[PATCH 12/17] hw/block/nvme: add support for scatter gather lists, Klaus Jensen, 2020/09/04
[PATCH 17/17] hw/block/nvme: change controller pci id, Klaus Jensen, 2020/09/04