Re: [PATCH] 9pfs: disable msize warning for synth driver

[Christian Schoenebeck]

On Dienstag, 8. September 2020 12:03:35 CEST Christian Schoenebeck wrote:
> On Dienstag, 8. September 2020 11:34:28 CEST Greg Kurz wrote:
> > On Tue, 08 Sep 2020 11:01:15 +0200
> > 
> > Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > > On Dienstag, 8. September 2020 10:10:36 CEST Greg Kurz wrote:
> > > > > > BTW, have you ever tried dealing with patchwork client's 'state'
> > > > > > feature
> > > > > > for already transmited patches on the list (new, rejected, etc.)?
> > > > > 
> > > > > Nope, never used patchwork's state at all and I've no idea on how it
> > > > > works... but I can ask to my former IBM colleagues at Ozlabs.
> > > > 
> > > > It seems that you need to be a "maintainer" from a patchwork
> > > > standpoint
> > > > to manipulate patch states.
> > > > 
> > > > https://patchwork.readthedocs.io/en/latest/usage/overview/#maintainers
> > > > 
> > > > ===========
> > > > Maintainers
> > > > 
> > > > Maintainers are a special type of user that with permissions to do
> > > > certain operations that regular Patchwork users can’t. Patchwork
> > > > maintainers usually have a 1:1 mapping with a project’s code
> > > > maintainers though this is not necessary.
> > > > 
> > > > The operations that a maintainer can invoke include:
> > > >     Change the state of a patch
> > > >     Archive a patch
> > > >     Delegate a patch, or be delegated a patch
> > > > 
> > > > ===========
> > > > 
> > > > No clue how to upgrade to maintainer though...
> > > 
> > > The command to change a patch state is, e.g.:
> > >   pwclient update -s Queued 11759645
> > > 
> > > When I do that I get this error:
> > >   The update action requires authentication, but no username or 
password
> > >   is configured
> > > 
> > > So looks like it would require somebody to create an account somewhere,
> > > wherever that is.
> > 
> > Which patchwork site are you using ?
> > 
> > https://patchwork.ozlabs.org/ or https://patchwork.kernel.org/ ?
> > 
> > Anyway, both support self account creation:
> > 
> > https://patchwork.ozlabs.org/register/
> > 
> > https://patchwork.kernel.org/register/
> > 
> > This allows you to update your own patches, but you need
> > to be maintainer to update other's.
> 
> Currently there are 3 maintainers registered for the QEMU patchwork project
> on ozlabs.org:
> 
>       https://patchwork.ozlabs.org/api/1.0/projects/14/
> 
> None for qemu on kernel.org:
> 
>       https://patchwork.kernel.org/api/1.0/projects/301/
> 
> My other test, setting state by email header didn't work BTW.

Looks like adding/removing maintainers is done by first getting the project's 
current json data, e.g.:

        https://patchwork.ozlabs.org/api/1.0/projects/14/

and then HTTP putting the (entire) modified json data with updated 
"maintainers" field:

        PUT /api/1.0/projects/14/ HTTP/1.1
        Host: patchwork.ozlabs.org
        Content-Type: application/json

        {
                <json-data-here>
        }

or by just sending the updated "maintainers" json field with HTTP "PATCH" 
command instead:

        PATCH /api/1.0/projects/14/ HTTP/1.1
        Host: patchwork.ozlabs.org
        Content-Type: application/json

        {
                "maintainers": ...
        }

As documented here:
https://patchwork.readthedocs.io/_/downloads/en/latest/pdf/
[page 90, 92]

As far as I can see, this is currently not implemented in the client. So 
that's manual, raw HTTP handling. No word in the docs though whether it's 
sufficient being a project maintainer for doing that, or if you even need to 
have a patchwork admin account.

And unfortunately patchwork does not seem to have a concept of submaintainers, 
so it seems to be all-or-nothing.

Best regards,
Christian Schoenebeck