qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 01/16] block: Fixes nfs on msys2/mingw


From: Eric Blake
Subject: Re: [PULL 01/16] block: Fixes nfs on msys2/mingw
Date: Tue, 8 Sep 2020 13:57:26 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/8/20 1:49 PM, Yonggang Luo wrote:
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
  block/nfs.c | 26 +++++++++++++++++---------
  1 file changed, 17 insertions(+), 9 deletions(-)

The commit message is too sparse. You say that nfs is broken, but fail to give any details how, or why this patch improves the situation. Also, the patch has no 'Reviewed-by' tag from anyone, and accepting unreviewed code into mainline can be risky (we tolerate it from well-established contributors, but you are still working toward that point).

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]