Re: [PATCH 03/20] hw/rx: Firmware and kernel loader.

[Philippe Mathieu-Daudé]

On 8/27/20 2:38 PM, Yoshinori Sato wrote:
> Suppoerted format.

Typo "Supported".

(Also, QEMU commits avoid to have a trailing dot '.'
 in their subject).

> ELF, HEX, SREC and Raw firmware.
> fit and Raw kernel image.
> 
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
>  include/hw/rx/loader.h |  35 ++++++++
>  hw/rx/loader.c         | 182 +++++++++++++++++++++++++++++++++++++++++
>  hw/rx/Kconfig          |   1 +
>  hw/rx/meson.build      |   1 +
>  4 files changed, 219 insertions(+)
>  create mode 100644 include/hw/rx/loader.h
>  create mode 100644 hw/rx/loader.c
> 
> diff --git a/include/hw/rx/loader.h b/include/hw/rx/loader.h
> new file mode 100644
> index 0000000000..71f3bd2bb3
> --- /dev/null
> +++ b/include/hw/rx/loader.h
> @@ -0,0 +1,35 @@
> +/*
> + * RX QEMU frimware loader
> + *
> + * Copyright (c) 2020 Yoshinori Sato
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2 or later, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along 
> with
> + * this program.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include "qapi/error.h"
> +#include "qemu/error-report.h"
> +
> +typedef struct {
> +    hwaddr ram_start;
> +    size_t ram_size;
> +    hwaddr entry;
> +    hwaddr kernel_entry;
> +    hwaddr dtb_address;
> +    const char *filename;
> +    const char *dtbname;
> +    const char *cmdline;
> +} rx_kernel_info_t;
> +
> +bool load_bios(const char *filename, int rom_size, Error **errp);
> +
> +bool load_kernel(rx_kernel_info_t *info);
> diff --git a/hw/rx/loader.c b/hw/rx/loader.c
> new file mode 100644
> index 0000000000..c262f3ef86
> --- /dev/null
> +++ b/hw/rx/loader.c
> @@ -0,0 +1,182 @@
> +/*
> + * RX QEMU frimware loader

Typo "firmware".

[...]