[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/16] block: get file-win32.c handle locking option consiste

From: Kevin Wolf
Subject: Re: [PATCH 08/16] block: get file-win32.c handle locking option consistence with file-posix.c
Date: Wed, 9 Sep 2020 10:19:31 +0200

Am 08.09.2020 um 21:48 hat Yonggang Luo geschrieben:
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>  block/file-win32.c | 23 +++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)

This is almost the same as my separately posted 'file-win32: Fix
"locking" option', except that you changed the order of variable
definitions which will cause a merge conflict.

When you take patches from other people, you should correctly attribute
them and not make them look as if they were your own.

Commit messages should not be empty, but explain the motivation for the

In this case, dropping the patch is easiest because my patch is already
in a pull request and will probably be merged soon.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]