[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 13/21] vmstate: Fixes test-vmstate.c on msys2/mingw
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 13/21] vmstate: Fixes test-vmstate.c on msys2/mingw |
Date: |
Wed, 9 Sep 2020 14:05:33 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Wed, Sep 09, 2020 at 05:46:09PM +0800, Yonggang Luo wrote:
> The vmstate are valid on win32, just need generate tmp path properly
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/test-vmstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f8de709a0b..51fe8e8ec5 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -34,7 +34,6 @@
> #include "qemu/module.h"
> #include "io/channel-file.h"
>
> -static char temp_file[] = "/tmp/vmst.test.XXXXXX";
> static int temp_fd;
>
>
> @@ -1487,6 +1486,7 @@ static void test_tmp_struct(void)
>
> int main(int argc, char **argv)
> {
> + g_autofree char *temp_file = g_strdup_printf("%s/vmst.test.XXXXXX",
> g_get_tmp_dir());
Could do with a line break before the arg. I'm surprised
'checkpatch.pl' didn't complain about this.
With the line break
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v2 08/21] tests: test-replication disable /replication/secondary/* on msys2/mingw., (continued)
- [PATCH v2 09/21] osdep: These function are only available on Non-Win32 system., Yonggang Luo, 2020/09/09
- [PATCH v2 10/21] meson: Use -b to ignore CR vs. CR-LF issues on Windows, Yonggang Luo, 2020/09/09
- [PATCH v2 11/21] meson: disable crypto tests are empty under win32, Yonggang Luo, 2020/09/09
- [PATCH v2 12/21] meson: remove empty else and duplicated gio deps, Yonggang Luo, 2020/09/09
- [PATCH v2 13/21] vmstate: Fixes test-vmstate.c on msys2/mingw, Yonggang Luo, 2020/09/09
- Re: [PATCH v2 13/21] vmstate: Fixes test-vmstate.c on msys2/mingw,
Daniel P . Berrangé <=
- [PATCH v2 15/21] tests: Convert g_free to g_autofree macro in test-logging.c, Yonggang Luo, 2020/09/09
- [PATCH v2 14/21] cirrus: Building freebsd in a single short, Yonggang Luo, 2020/09/09
- [PATCH v2 16/21] rcu: add uninit destructor for rcu, Yonggang Luo, 2020/09/09
- [PATCH v2 17/21] tests: Fixes test-io-channel-socket.c tests under msys2/mingw, Yonggang Luo, 2020/09/09
- [PATCH v2 18/21] tests: fixes aio-win32 about aio_remove_fd_handler, get it consistence with aio-posix.c, Yonggang Luo, 2020/09/09