Re: [PATCH 18/29] block/export: Add 'id' option to block-export-add

[Max Reitz]

On 07.09.20 20:20, Kevin Wolf wrote:
> We'll need an id to identify block exports in monitor commands. This
> adds one.
> 
> Note that this is different from the 'name' option in the NBD server,
> which is the externally visible export name. While block export ids need
> to be unique in the whole process, export names must be unique only for
> the same server. Different export types or (potentially in the future)
> multiple NBD servers can have the same export name externally, but still
> need different block export ids internally.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  qapi/block-export.json               |  5 +++++
>  include/block/export.h               |  3 +++
>  block/export/export.c                | 26 ++++++++++++++++++++++++++
>  blockdev-nbd.c                       |  1 +
>  qemu-nbd.c                           |  1 +
>  storage-daemon/qemu-storage-daemon.c |  2 +-
>  tests/qemu-iotests/223.out           |  4 ++--
>  7 files changed, 39 insertions(+), 3 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

signature.asc
Description: OpenPGP digital signature