[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/i386/kvm: Add missing fallthrough comment
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] target/i386/kvm: Add missing fallthrough comment |
|
Date: |
Fri, 11 Sep 2020 15:43:43 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 11/09/20 14:53, Thomas Huth wrote:
> Let's make this file compilable with -Werror=implicit-fallthrough :
> Looking at the code, it seems like the fallthrough is intended here,
> so we should add the corresponding "/* fallthrough */" comment here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/i386/kvm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> index 205b68bc0c..283d3305d5 100644
> --- a/target/i386/kvm.c
> +++ b/target/i386/kvm.c
> @@ -1568,6 +1568,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
> if (env->nr_dies < 2) {
> break;
> }
> + /* fallthrough */
> case 4:
> case 0xb:
> case 0xd:
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>