[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

From: Yonggang Luo
Subject: Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches
Date: Mon, 14 Sep 2020 14:27:07 +0800

On Mon, Sep 14, 2020 at 2:10 PM Thomas Huth <thuth@redhat.com> wrote:
On 13/09/2020 00.44, Yonggang Luo wrote:
> It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and
> disable partial test-char tests.
> And then fixes all unit tests failure on msys2/mingw
> This fixes the reviews suggested in the mailling list
> All cirrus CI are passed


since you're very often sending new versions of your patch series, could
you please add a history to the cover letter to say what you changed in
each version? Otherwise, your work is very hard to follow.
I'd also suggest to really slow down the sending a little bit. Let your
patches mature in your tests first, then send out a new series only if
you feel that they are really ready. Nobody has the bandwith to review a
patch series with 27 patches each day...

Thanks, I am learning how to submit patches properly, in old days,  when I am using pull request on github have no such problems. easy to follow up 


Yonggang Luo

reply via email to

[Prev in Thread] Current Thread [Next in Thread]