Re: [PATCH v2] cphp: remove deprecated cpu-add command(s)

[Michal Privoznik]

On 9/14/20 9:46 AM, Igor Mammedov wrote:
> theses were deprecated since 4.0, remove both HMP and QMP variants.
>
> Users should use device_add command instead. To get list of
> possible CPUs and options, use 'info hotpluggable-cpus' HMP
> or query-hotpluggable-cpus QMP command.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>   include/hw/boards.h         |   1 -
>   include/hw/i386/pc.h        |   1 -
>   include/monitor/hmp.h       |   1 -
>   docs/system/deprecated.rst  |  25 +++++----
>   hmp-commands.hx             |  15 ------
>   hw/core/machine-hmp-cmds.c  |  12 -----
>   hw/core/machine-qmp-cmds.c  |  12 -----
>   hw/i386/pc.c                |  27 ----------
>   hw/i386/pc_piix.c           |   1 -
>   hw/s390x/s390-virtio-ccw.c  |  12 -----
>   qapi/machine.json           |  24 ---------
>   tests/qtest/cpu-plug-test.c | 100 ++++--------------------------------
>   tests/qtest/test-hmp.c      |   1 -
>   13 files changed, 21 insertions(+), 211 deletions(-)

Thanks to Peter Libvirt uses device_add instead cpu_add whenever 
possible. Hence this is okay from Libvirt's POV.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal