[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 0/4] Introduce Xilinx ZynqMP CAN controller

From: Peter Maydell
Subject: Re: [PATCH v9 0/4] Introduce Xilinx ZynqMP CAN controller
Date: Mon, 14 Sep 2020 16:06:29 +0100

On Mon, 14 Sep 2020 at 14:16, Peter Maydell <peter.maydell@linaro.org> wrote:
> On Thu, 13 Aug 2020 at 01:33, Vikram Garhwal <fnu.vikram@xilinx.com> wrote:
> > Vikram Garhwal (4):
> >   hw/net/can: Introduce Xilinx ZynqMP CAN controller
> >   xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers
> >   tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller
> >   MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN controller
> Applied to target-arm.next, thanks. (I had to make some
> minor fixups to convert the makefile changes to the new
> meson build system.)

I had to drop these patches because in the full merge build
test configs they failed to link because nothing was pulling
in the generic CONFIG_CAN_BUS files.

Could you rebase this, make the necessary changes to get it
to work with meson[*], and also make whatever Kconfig changes
are necessary so that the ZynqMP CAN controller device
declares its dependency on the generic CONFIG_CAN_BUS code,

[*] you might want to look at the versions of the patches
I just sent out in my v1 pullreq today, but basically
instead of the Makefile.include changes you want some
simple one-liner changes to meson.build files, and also
tests/qtest/xlnx-can-test.c needs to #include "libqos/libqtest.h"
rather than just "libqtest.h".

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]