Re: [PATCH 06/15] spapr: Simplify error handling in do_client

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/15] spapr: Simplify error handling in do_client_architectu

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH 06/15] spapr: Simplify error handling in do_client_architecture_support()
Date:	Tue, 15 Sep 2020 15:03:24 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/14/20 2:34 PM, Greg Kurz wrote:
> Use the return value of ppc_set_compat_all() to check failures,
> which is preferred over hijacking local_err.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>  hw/ppc/spapr_hcall.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-DaudÃ© <philmd@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 03/15] ppc: Fix return value in cpu_post_load() error path, (continued)
- [PATCH 03/15] ppc: Fix return value in cpu_post_load() error path, Greg Kurz, 2020/09/14
  - Re: [PATCH 03/15] ppc: Fix return value in cpu_post_load() error path, Vladimir Sementsov-Ogievskiy, 2020/09/15
  - Re: [PATCH 03/15] ppc: Fix return value in cpu_post_load() error path, Philippe Mathieu-Daudé, 2020/09/15
- [PATCH 05/15] spapr: Get rid of cas_check_pvr() error reporting, Greg Kurz, 2020/09/14
  - Re: [PATCH 05/15] spapr: Get rid of cas_check_pvr() error reporting, Vladimir Sementsov-Ogievskiy, 2020/09/15
    - Re: [SPAM] Re: [PATCH 05/15] spapr: Get rid of cas_check_pvr() error reporting, Greg Kurz, 2020/09/15
- [PATCH 07/15] spapr: Simplify error handling in spapr_vio_busdev_realize(), Greg Kurz, 2020/09/14
  - Re: [PATCH 07/15] spapr: Simplify error handling in spapr_vio_busdev_realize(), Vladimir Sementsov-Ogievskiy, 2020/09/15
- [PATCH 06/15] spapr: Simplify error handling in do_client_architecture_support(), Greg Kurz, 2020/09/14
  - Re: [PATCH 06/15] spapr: Simplify error handling in do_client_architecture_support(), Vladimir Sementsov-Ogievskiy, 2020/09/15
  - Re: [PATCH 06/15] spapr: Simplify error handling in do_client_architecture_support(), Philippe Mathieu-Daudé <=
- [PATCH 08/15] spapr: Add a return value to spapr_drc_attach(), Greg Kurz, 2020/09/14
  - Re: [PATCH 08/15] spapr: Add a return value to spapr_drc_attach(), Vladimir Sementsov-Ogievskiy, 2020/09/15
  - Re: [PATCH 08/15] spapr: Add a return value to spapr_drc_attach(), Philippe Mathieu-Daudé, 2020/09/15
- [PATCH 09/15] spapr: Simplify error handling in prop_get_fdt(), Greg Kurz, 2020/09/14
  - Re: [PATCH 09/15] spapr: Simplify error handling in prop_get_fdt(), Vladimir Sementsov-Ogievskiy, 2020/09/15
- [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), Greg Kurz, 2020/09/14
  - Re: [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), Vladimir Sementsov-Ogievskiy, 2020/09/15
  - Re: [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), Philippe Mathieu-Daudé, 2020/09/15
    - Re: [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), Greg Kurz, 2020/09/15
    - Re: [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), David Gibson, 2020/09/16

Prev by Date: Re: [PATCH 04/15] spapr: Simplify error handling in callers of ppc_set_compat()
Next by Date: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1
Previous by thread: Re: [PATCH 06/15] spapr: Simplify error handling in do_client_architecture_support()
Next by thread: [PATCH 08/15] spapr: Add a return value to spapr_drc_attach()
Index(es):
- Date
- Thread