Re: [PATCH v4 00/11] i440fx/acpi: addition of feature and bug fixes.

[Ani Sinha]

Got it.

On Wed, Sep 16, 2020 at 12:46 PM Igor Mammedov <imammedo@redhat.com> wrote:
>
> On Wed, 16 Sep 2020 11:43:24 +0530
> Ani Sinha <ani@anisinha.ca> wrote:
>
> > In v4 I have made the following changes:
> >
> > - a cosmetic change for patch #4. Commit log was updated as per Igor's 
> > suggestion.
> > - patches #10 and #11 were added to unit test patch #9.
> >
> > The DSDT table after disabling hotplug on the root bus and the pci bridges 
> > is shown here:
> >
> > https://pastebin.ubuntu.com/p/WvpYYjpPN8/
> >
> > This was generated by disassembling the newly added DSDT golden master 
> > binary table blob
> > DSDT.hpbrroot.
> >
> > I sincerely hope this is the final iteration of the set of patches.  The 
> > patches has been
> > unit tested on top of latest qemu upstream master branch.
>
> usually one includes Reviewed|...|-by tags from previous version,
> unless there was a functional change in a reviewed patch or you
> feel that trivial changes (if any) deserve review.
>
>
> > Ani Sinha (11):
> >   tests/acpi: document addition of table DSDT.roothp for unit testing
> >     root pci hotplug on/off
> >   tests/acpi: add a new unit test to test hotplug off/on feature on the
> >     root pci bus
> >   tests/acpi: add a new ACPI table in order to test root pci hotplug
> >     on/off
> >   Fix a gap where acpi_pcihp_find_hotplug_bus() returns a
> >     non-hotpluggable bus
> >   i440fx/acpi: do not add hotplug related amls for cold plugged bridges
> >   tests/acpi: list added acpi table binary file for pci bridge hotplug
> >     test
> >   tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support'
> >     bridge flag
> >   tests/acpi: add newly added acpi DSDT table blob for pci bridge
> >     hotplug flag
> >   piix4: don't reserve hw resources when hotplug is off globally
> >   tests/acpi: unit test exercizing hotplug off for pci root bus & bridge
> >     in i440fx
> >   tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx
> >     hotplug
> >
> >  hw/acpi/pcihp.c                   |  15 ++++++++++
> >  hw/acpi/piix4.c                   |   6 ++--
> >  hw/i386/acpi-build.c              |  37 ++++++++++++++---------
> >  tests/data/acpi/pc/DSDT.hpbridge  | Bin 0 -> 4895 bytes
> >  tests/data/acpi/pc/DSDT.hpbrroot  | Bin 0 -> 2953 bytes
> >  tests/data/acpi/pc/DSDT.roothp    | Bin 0 -> 5130 bytes
> >  tests/data/acpi/q35/DSDT          | Bin 7678 -> 7670 bytes
> >  tests/data/acpi/q35/DSDT.acpihmat | Bin 9002 -> 8994 bytes
> >  tests/data/acpi/q35/DSDT.bridge   | Bin 7695 -> 7688 bytes
> >  tests/data/acpi/q35/DSDT.cphp     | Bin 8141 -> 8133 bytes
> >  tests/data/acpi/q35/DSDT.dimmpxm  | Bin 9331 -> 9323 bytes
> >  tests/data/acpi/q35/DSDT.ipmibt   | Bin 7753 -> 7745 bytes
> >  tests/data/acpi/q35/DSDT.memhp    | Bin 9037 -> 9029 bytes
> >  tests/data/acpi/q35/DSDT.mmio64   | Bin 8808 -> 8801 bytes
> >  tests/data/acpi/q35/DSDT.numamem  | Bin 7684 -> 7676 bytes
> >  tests/data/acpi/q35/DSDT.tis      | Bin 8283 -> 8276 bytes
> >  tests/qtest/bios-tables-test.c    |  47 ++++++++++++++++++++++++++++++
> >  17 files changed, 90 insertions(+), 15 deletions(-)
> >  create mode 100644 tests/data/acpi/pc/DSDT.hpbridge
> >  create mode 100644 tests/data/acpi/pc/DSDT.hpbrroot
> >  create mode 100644 tests/data/acpi/pc/DSDT.roothp
> >
>