[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] hw/timer/hpet: Fix compiler errors with -DHPET_DEBUG
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 0/2] hw/timer/hpet: Fix compiler errors with -DHPET_DEBUG |
Date: |
Wed, 16 Sep 2020 11:15:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Le 13/09/2020 à 13:42, Philippe Mathieu-Daudé a écrit :
> Cc'ing qemu-trivial@
>
> On 9/10/20 2:53 PM, Dov Murik wrote:
>> On 09/09/2020 20:24, Philippe Mathieu-Daudé wrote:
>>> On 9/9/20 10:36 AM, Dov Murik wrote:
>>>> Fix several compiler errors when compiling withe -DHPET_DEBUG.
>>>>
>>>> Steps to reproduce the issue:
>>>>
>>>> mkdir build
>>>> cd build
>>>> ../configure --target-list=x86_64-softmmu
>>>> --extra-cflags=-DHPET_DEBUG
>>>> make
>>>>
>>>> Dov Murik (2):
>>>> hw/timer/hpet: Remove unused functions hpet_ram_readb, hpet_ram_readw
>>>> hw/timer/hpet: Fix debug format strings
>>>>
>>>> hw/timer/hpet.c | 27 +++++++--------------------
>>>> 1 file changed, 7 insertions(+), 20 deletions(-)
>>>>
>>>
>>> I sent almost the same patches last week :)
>>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg736836.html
>>
>> Oops, missed that. You're right.
>>
>>> You seem to fix a 4th format, can you rebase on top? (As these
>>> patches have already been queued).
>>
>> Actually there's a small issue in one of your suggested fixes: you added
>> "0x" but kept the "%#". I think it should be without the "#" (also
>> according to the coding style document).
>>
>> I suggest you fix this small issue, and also add any changes you wish
>> from this patchset; then we can throw my patchset to the bin.
>
> Let's use your patchset instead.
>
> Series:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
Series applied to my trivial-patches branch.
Thanks,
Laurent