[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] migration: Silence compiler warning in global_state_store_ru

From: Eric Blake
Subject: Re: [PATCH] migration: Silence compiler warning in global_state_store_running()
Date: Wed, 16 Sep 2020 12:42:12 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/16/20 12:19 PM, Thomas Huth wrote:
GCC 9.3.0 on Ubuntu complains:

In file included from /usr/include/string.h:495,
                  from /home/travis/build/huth/qemu/include/qemu/osdep.h:87,
                  from ../migration/global_state.c:13:
In function ‘strncpy’,
     inlined from ‘global_state_store_running’ at 
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: 
‘__builtin_strncpy’ specified bound 100 equals destination size 
   106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos 
       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

... but we apparently really want to do the strncpy here. Silence the
warning with QEMU_NONSTRING.

Signed-off-by: Thomas Huth <thuth@redhat.com>
  migration/global_state.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/migration/global_state.c b/migration/global_state.c
index 25311479a4..f1355d7d97 100644
--- a/migration/global_state.c
+++ b/migration/global_state.c
@@ -43,9 +43,9 @@ int global_state_store(void)
  void global_state_store_running(void)
      const char *state = RunState_str(RUN_STATE_RUNNING);
+    QEMU_NONSTRING char *dest = (char *)global_state.runstate;

Do we still need the cast to char*?

      assert(strlen(state) < sizeof(global_state.runstate));
-    strncpy((char *)global_state.runstate,
-           state, sizeof(global_state.runstate));
+    strncpy(dest, state, sizeof(global_state.runstate));

Reviewed-by: Eric Blake <eblake@redhat.com>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]