Re: [PATCH v2 04/10] disas: Clean up CPUDebug initialization

[Alex Bennée]

Thomas Huth <thuth@redhat.com> writes:

> On 15/09/2020 01.02, Richard Henderson wrote:
>> Rename several functions, dropping "generic" and making "host"
>> vs "target" clearer.  Make a bunch of functions static that are
>> not used outside this file. Replace INIT_DISASSEMBLE_INFO with
>> a trio of functions.
>> 
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>  include/disas/dis-asm.h |  60 --------
>>  disas.c                 | 326 ++++++++++++++++++----------------------
>>  2 files changed, 148 insertions(+), 238 deletions(-)
>> 
>> diff --git a/include/disas/dis-asm.h b/include/disas/dis-asm.h
>> index 9856bf7921..d2418c977e 100644
>> --- a/include/disas/dis-asm.h
>> +++ b/include/disas/dis-asm.h
>> @@ -461,67 +461,7 @@ int print_insn_riscv32          (bfd_vma, 
>> disassemble_info*);
>>  int print_insn_riscv64          (bfd_vma, disassemble_info*);
>>  int print_insn_rx(bfd_vma, disassemble_info *);
>>  
>> -#if 0
>> -/* Fetch the disassembler for a given BFD, if that support is available.  */
>> -disassembler_ftype disassembler(bfd *);
>> -#endif
>> -
>>
>
> By the way, while you're at it, could you please also remove the form
> feed character in this file here? ... that looks really confusing in my
> e-mail client otherwise.

I'm not entirely convinced that is from Richard. I've been seeing rouge
^L and ^M's from all sorts of normally unix clean contributors. I smell
mailing list shenanigans.

-- 
Alex Bennée