[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 09/22] i386: add reserved FEAT_HYPERV_ECX CPUID leaf
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH RFC 09/22] i386: add reserved FEAT_HYPERV_ECX CPUID leaf |
Date: |
Fri, 18 Sep 2020 18:25:15 -0400 |
On Fri, Sep 04, 2020 at 04:54:18PM +0200, Vitaly Kuznetsov wrote:
> As a preparation to expanding Hyper-V CPU features early, add
> reserved FEAT_HYPERV_ECX CPUID leaf.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> target/i386/cpu.c | 5 +++++
> target/i386/cpu.h | 1 +
> target/i386/kvm.c | 2 ++
> 3 files changed, 8 insertions(+)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index ef3c672cf415..70588571ccb1 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -974,6 +974,11 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS]
> = {
> },
> .cpuid = { .eax = 0x40000003, .reg = R_EBX, },
> },
> + [FEAT_HYPERV_ECX] = {
> + .type = CPUID_FEATURE_WORD,
> + /* reserved */
What does "reserved" mean here?
> + .cpuid = { .eax = 0x40000003, .reg = R_ECX, },
> + },
> [FEAT_HYPERV_EDX] = {
> .type = CPUID_FEATURE_WORD,
> .feat_names = {
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index 095d0bf75493..39e0e89aa41f 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -521,6 +521,7 @@ typedef enum FeatureWord {
> FEAT_KVM_HINTS, /* CPUID[4000_0001].EDX */
> FEAT_HYPERV_EAX, /* CPUID[4000_0003].EAX */
> FEAT_HYPERV_EBX, /* CPUID[4000_0003].EBX */
> + FEAT_HYPERV_ECX, /* CPUID[4000_0003].ECX */
> FEAT_HYPERV_EDX, /* CPUID[4000_0003].EDX */
> FEAT_HV_RECOMM_EAX, /* CPUID[4000_0004].EAX */
> FEAT_HV_NESTED_EAX, /* CPUID[4000_000A].EAX */
> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> index 96ac719adca1..259be2d514dd 100644
> --- a/target/i386/kvm.c
> +++ b/target/i386/kvm.c
> @@ -1251,6 +1251,7 @@ static int hyperv_handle_properties(CPUState *cs,
> if (c) {
> env->features[FEAT_HYPERV_EAX] = c->eax;
> env->features[FEAT_HYPERV_EBX] = c->ebx;
> + env->features[FEAT_HYPERV_ECX] = c->ecx;
> env->features[FEAT_HYPERV_EDX] = c->edx;
> }
>
> @@ -1350,6 +1351,7 @@ static int hyperv_handle_properties(CPUState *cs,
> c->function = HV_CPUID_FEATURES;
> c->eax = env->features[FEAT_HYPERV_EAX];
> c->ebx = env->features[FEAT_HYPERV_EBX];
> + c->ecx = env->features[FEAT_HYPERV_ECX];
> c->edx = env->features[FEAT_HYPERV_EDX];
>
> c = &cpuid_ent[cpuid_i++];
> --
> 2.25.4
>
--
Eduardo
- Re: [PATCH RFC 06/22] i386: move hyperv_limits initialization to x86_cpu_realizefn(), (continued)
- [PATCH RFC 07/22] i386: fill in FEAT_HYPERV_EDX from edx instead of eax, Vitaly Kuznetsov, 2020/09/04
- [PATCH RFC 11/22] i386: add reserved FEAT_HV_NESTED_EBX/ECX/EDX CPUID leaves, Vitaly Kuznetsov, 2020/09/04
- [PATCH RFC 08/22] i386: invert hyperv_spinlock_attempts setting logic with hv_passthrough, Vitaly Kuznetsov, 2020/09/04
- [PATCH RFC 02/22] i386: drop x86_cpu_get_supported_feature_word() forward declaration, Vitaly Kuznetsov, 2020/09/04
- [PATCH RFC 10/22] i386: add reserved FEAT_HV_RECOMM_ECX/FEAT_HV_RECOMM_EDX CPUID leaves, Vitaly Kuznetsov, 2020/09/04
- [PATCH RFC 05/22] i386: move hyperv_version_id initialization to x86_cpu_realizefn(), Vitaly Kuznetsov, 2020/09/04
- [PATCH RFC 09/22] i386: add reserved FEAT_HYPERV_ECX CPUID leaf, Vitaly Kuznetsov, 2020/09/04
- Re: [PATCH RFC 09/22] i386: add reserved FEAT_HYPERV_ECX CPUID leaf,
Eduardo Habkost <=
- [PATCH RFC 13/22] i386: split hyperv_handle_properties() into hyperv_expand_features()/hyperv_fill_cpuids(), Vitaly Kuznetsov, 2020/09/04
- [PATCH RFC 12/22] i386: always fill Hyper-V CPUID feature leaves from X86CPU data, Vitaly Kuznetsov, 2020/09/04
- [PATCH RFC 15/22] i386: switch hyperv_expand_features() to using error_setg(), Vitaly Kuznetsov, 2020/09/04
- [PATCH RFC 18/22] i386: prefer system KVM_GET_SUPPORTED_HV_CPUID ioctl over vCPU's one, Vitaly Kuznetsov, 2020/09/04
- [PATCH RFC 22/22] i386: expand Hyper-V features early, Vitaly Kuznetsov, 2020/09/04